Skip to content

Swagger specifications for 2019-10-01 Tags API for resources and subscriptions#7716

Merged
ChenTanyi merged 15 commits intoAzure:masterfrom
Grayer123:feature/tagApi-2019-10-01
Nov 22, 2019
Merged

Swagger specifications for 2019-10-01 Tags API for resources and subscriptions#7716
ChenTanyi merged 15 commits intoAzure:masterfrom
Grayer123:feature/tagApi-2019-10-01

Conversation

@Grayer123
Copy link
Copy Markdown
Contributor

@Grayer123 Grayer123 commented Nov 5, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

  • Added swagger api sec for Tags (tracked resources): Put/ Patch/ Get/ Delete;
  • Added swagger api sec for Tags (subscription): Put/ Patch/ Get/ Delete;

Detailed Changes:

  • Copy 2019-08-01 -> 2019-10-01
  • Create 2019-10-01 resources spec for tag apis
  • Add Get/ Put Tags resources examples to examples folder

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@Grayer123 Grayer123 requested a review from Tiano2017 as a code owner November 5, 2019 23:03
@azuresdkci azuresdkci requested a review from ChenTanyi November 5, 2019 23:04
@AutorestCI AutorestCI mentioned this pull request Nov 5, 2019
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Nov 5, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#8801

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Nov 5, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Nov 5, 2019

Can one of the admins verify this patch?

@raych1 raych1 mentioned this pull request Nov 6, 2019
Closed
5 tasks
@hamidtirmizi
Copy link
Copy Markdown
Contributor

hamidtirmizi commented Nov 6, 2019

How about "Swagger specifications for 2019-10-01 Tags API for resources and subscriptions"

@Grayer123 Grayer123 changed the title Added Swagger api spec for tags (tracked resources and subscription) Swagger specifications for 2019-10-01 Tags API for resources and subscriptions Nov 6, 2019
@ChenTanyi ChenTanyi added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 6, 2019
anthony-c-martin
anthony-c-martin requested changes Nov 13, 2019
View reviewed changes
ravbhatnagar
ravbhatnagar reviewed Nov 14, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@ravbhatnagar ravbhatnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments

specification/resources/resource-manager/Microsoft.Resources/stable/2019-10-01/resources.json
"type": "object",
"description": "Tag Request for Patch operation.",
"properties": {
"operation": {
Copy link
Copy Markdown
Contributor

@ravbhatnagar ravbhatnagar Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this I think should be generalized. We should create an Azure extension (similar to x-ms-long-running). and then any service who want to support advanced patch capabilities can leverage that extension. something like - "x-ms-patch-mode"
@anthony-c-martin @KrisBash - thoughts?

Copy link
Copy Markdown
Contributor Author

@Grayer123 Grayer123 Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the request body for put and patch is different here, we have defined two entities: TagPatchRequest and TagRequest.

@xseeseesee xseeseesee mentioned this pull request Nov 14, 2019
Merged
5 tasks
@hamidtirmizi hamidtirmizi removed the request for review from Tiano2017 November 20, 2019 21:52
@Grayer123
Copy link
Copy Markdown
Contributor Author

Grayer123 commented Nov 20, 2019

@ChenTanyi Hello, Tianyi, Arm Team has approved this pull request, could we merge this PR? Thanks.

@ChenTanyi
Copy link
Copy Markdown
Contributor

ChenTanyi commented Nov 21, 2019

@Grayer123 sorry, I haven't seen the arm sign off label. I can't merge it. If the arm team approved, they would change the label to arm sign off

@anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 21, 2019
@Grayer123
Copy link
Copy Markdown
Contributor Author

Grayer123 commented Nov 21, 2019

@ChenTanyi Thanks. Please merge the PR

@ChenTanyi ChenTanyi merged commit 29737d5 into Azure:master Nov 22, 2019
@AutorestCI AutorestCI mentioned this pull request Nov 22, 2019
Merged
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
@Grayer123 @AnuTalluri
Swagger specifications for 2019-10-01 Tags API for resources and subs…
6f5118c 
…criptions (Azure#7716)

* Added previous version spec as initial commit.

* Modified all the api-version for the existing example files.

* Added tag related api spec to resource file as well add example files.

* Modified readme related files.

* Execute prettier to reorganize the file.

* Pull request comments related fixes.

* Use scope to support nested resources for tags.

* Update examples based on scope change.

* Remove first slash to resolve model validation error.

* Combine tracked resource and subscription apis for tags.

* Modifed the examples to match the changes in resource.json.

* Utilize the shared parameters, and update the examples.

* Removing "required" from TagPatchRequest as getting R2016 error.

* Collapse TagRequest and TagResponse into TagsResource.

* Removed 404 response as covered in default scenario, as well updated corresponding examples.
@Grayer123 Grayer123 mentioned this pull request Jan 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

@ChenTanyi ChenTanyi Awaiting requested review from ChenTanyi

@raych1 raych1 Awaiting requested review from raych1

+2 more reviewers

@ravbhatnagar ravbhatnagar ravbhatnagar left review comments

@hamidtirmizi hamidtirmizi hamidtirmizi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ChenTanyi ChenTanyi

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Grayer123 @AutorestCI @azuresdkci @hamidtirmizi @ChenTanyi @ravbhatnagar @anthony-c-martin